Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to AWS SDK v2 (#1938) #1950

Merged
merged 18 commits into from
Apr 29, 2024
Merged

Upgrade to AWS SDK v2 (#1938) #1950

merged 18 commits into from
Apr 29, 2024

Conversation

nesangcode
Copy link
Contributor

What is the problem I am trying to address?

The existing AWS SDK we use is in maintenance mode. We should migrate to v2 when we can.

How is the fix applied?

Refactor all AWS SDK v1 related code to v2 one.

What GitHub issue(s) does this PR fix or close?

Fixes #1938

@nesangcode nesangcode requested a review from a team as a code owner April 20, 2024 12:57
@matt0x6F matt0x6F added the dependencies Pull requests that update a dependency file label Apr 20, 2024
Copy link
Contributor

@matt0x6F matt0x6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a minor documentation change. Everything looks good otherwise!

pkg/storage/minio/minio.go Show resolved Hide resolved
Copy link
Contributor

@matt0x6F matt0x6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@matt0x6F matt0x6F merged commit 900cb4f into gomods:main Apr 29, 2024
11 checks passed
DrPsychick referenced this pull request in gomods/athens-charts May 2, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [gomods/athens](https://togithub.com/gomods/athens) | minor |
`v0.13.3` -> `v0.14.0` |

---

### Release Notes

<details>
<summary>gomods/athens (gomods/athens)</summary>

### [`v0.14.0`](https://togithub.com/gomods/athens/releases/tag/v0.14.0)

[Compare
Source](https://togithub.com/gomods/athens/compare/v0.13.3...v0.14.0)

#### What's Changed

- update-go-pkg(deps): bump github.com/aws/aws-sdk-go from 1.44.220 to
1.51.21 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/gomods/athens/pull/1942](https://togithub.com/gomods/athens/pull/1942)
- Add an introduction page as the home page by
[@&#8203;matt0x6F](https://togithub.com/matt0x6F) in
[https://github.com/gomods/athens/pull/1945](https://togithub.com/gomods/athens/pull/1945)
- build(deps): bump golang.org/x/net from 0.22.0 to 0.23.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/gomods/athens/pull/1946](https://togithub.com/gomods/athens/pull/1946)
- Add logging configuration docs by
[@&#8203;matt0x6F](https://togithub.com/matt0x6F) in
[https://github.com/gomods/athens/pull/1952](https://togithub.com/gomods/athens/pull/1952)
- Docs overhaul by [@&#8203;matt0x6F](https://togithub.com/matt0x6F) in
[https://github.com/gomods/athens/pull/1954](https://togithub.com/gomods/athens/pull/1954)
- Upgrade to AWS SDK v2
([#&#8203;1938](https://togithub.com/gomods/athens/issues/1938)) by
[@&#8203;nesangcode](https://togithub.com/nesangcode) in
[https://github.com/gomods/athens/pull/1950](https://togithub.com/gomods/athens/pull/1950)
- update-github-action(deps): bump golangci/golangci-lint-action from 4
to 5 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/gomods/athens/pull/1956](https://togithub.com/gomods/athens/pull/1956)
- Bump
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
from 0.25.0 to 0.46.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/gomods/athens/pull/1901](https://togithub.com/gomods/athens/pull/1901)
- update-go-pkg(deps): bump github.com/unrolled/secure from
0.0.0-20181221173256-0d6b5bb13069 to 1.14.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/gomods/athens/pull/1955](https://togithub.com/gomods/athens/pull/1955)

#### New Contributors

- [@&#8203;nesangcode](https://togithub.com/nesangcode) made their first
contribution in
[https://github.com/gomods/athens/pull/1950](https://togithub.com/gomods/athens/pull/1950)

**Full Changelog**:
gomods/athens@v0.13.3...v0.14.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/gomods/athens-charts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: DrPsychick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use AWS SDK v2 for Go
2 participants