This repository has been archived by the owner on Jul 31, 2024. It is now read-only.
tests: lightdb: use GOLIOTH_SAMPLES_COMMON for hardcoded credentials #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those tests rely on hardcoded credentials, which were moved to `samples/common/`. Use `CONFIG_GOLIOTH_SAMPLES_COMMON=y` to make use of them and fix test execution. Fixes: 7fa0949 ("auth: Move hardcoded PSKs to samples") Signed-off-by: Marcin Niestroj <[email protected]>
|
Visit the preview URL for this PR (updated for commit 94f0491): https://golioth-zephyr-sdk-doxygen-dev--pr419-tests-lightdb-sa-dkem3hwk.web.app (expires Fri, 11 Aug 2023 08:15:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a389eefadf4b4b68a539327b3459dd66c142cf49 |
sam-golioth
approved these changes
Aug 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those tests rely on hardcoded credentials, which were moved to
samples/common/. UseCONFIG_GOLIOTH_SAMPLES_COMMON=yto make use ofthem and fix test execution.
Fixes: 7fa0949 ("auth: Move hardcoded PSKs to samples")