examples: zephyr: certificate_provisioning: pytest improvements #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This suppresses flake8's "unexpected spaces around keyword / parameter equals" warning. Signed-off-by: Marcin Niestroj <[email protected]>
Pytest invokes shell scripts, which create and use certificates in current working directory. This means that those files are created in current twister invocation directory. Use Zephyr example build directory, so that each example has its own certificates. Additionally this allows to keep twister CWD uncluttered. Signed-off-by: Marcin Niestroj <[email protected]>
Right now it is necessary to either specify --pytest-args=--device-port=SERIAL over commandline or set 'CI_DEVICENAME_PORT' and 'hil_board' environment variables. This makes little sense in context of manual testing, since twister serial port should be used by default for mcumgr communication. Fallback to twister serial when neither CLI nor environment variables specify explicit serial port. Signed-off-by: Marcin Niestroj <[email protected]>
mniestroj
requested review from
sam-golioth and
szczys
and removed request for
sam-golioth
|
Visit the preview URL for this PR (updated for commit 7810c82): https://golioth-firmware-sdk-doxygen-dev--pr671-zephyr-certifi-ukyropaa.web.app (expires Wed, 20 Nov 2024 21:28:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
sam-golioth
approved these changes
Nov 13, 2024
szczys
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=to suppress flake8's "unexpected spaces around keyword / parameter equals"warning
current directory from which twister is invoked)
--device-portCLI argument (orCI_DEVNAME_PORTenvironmentvariable) is not required