libcoap: block-upload: allow server-negotiated block size #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 8d12cab): https://golioth-firmware-sdk-doxygen-dev--pr648-szczys-libcoap-wzm2hfhb.web.app (expires Mon, 14 Oct 2024 21:44:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
sam-golioth
approved these changes
Oct 7, 2024
When the server responds to a block upload request with a different block size, supply the new value to the callback so it may be used to set up the size of the next block. Signed-off-by: Mike Szczys <[email protected]>
Use the negotiated block size when initializing the block1 option of the coap packet. This moves the use of the compiled-in CONFIG_GOLIOTH_BLOCKWISE_UPLOAD_MAX_BLOCK_SIZE value to the initialization step of the negotiated value, and allows for the negotiated value to be updated based on the server preference, then used for all subsequent coap requests in the block upload process. Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/libcoap-server-suggests
branch
from
023c0ba
to
8d12cab
Compare
Code Coverage
|
Codecov ReportAttention: Patch coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing a block upload, honor requests from the server for a smaller block size.
Resolves: https://github.com/golioth/firmware-issue-tracker/issues/670