Update functionDescriptorToId tests for changes to function names (fi…

…nos#3122)
goldmansachs · Sep 25, 2024 · 3278ab9 · 3278ab9
1 parent ea38134
commit 3278ab9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/.../src/test/java/org/finos/legend/engine/pure/code/core/TestCoreCompiledStateIntegrity.java b/.../src/test/java/org/finos/legend/engine/pure/code/core/TestCoreCompiledStateIntegrity.java
@@ -32,15 +32,6 @@ public static void initialize()
         initialize(codeStorage);
     }
 
-    @Test
-    @Ignore
-    @Override
-    public void testPackageHasChildrenWithDuplicateNames()
-    {
-        // TODO fix this test
-        super.testPackageHasChildrenWithDuplicateNames();
-    }
-
     @Test
     @Ignore
     @Override

diff --git a/...main/resources/core_functions_unclassified/meta/type/function/functionDescriptorToId.pure b/...main/resources/core_functions_unclassified/meta/type/function/functionDescriptorToId.pure
@@ -43,9 +43,9 @@ function <<test.Test>> meta::pure::functions::meta::tests::functionDescriptorToI
 function <<test.Test>> meta::pure::functions::meta::tests::functionDescriptorToId::testFunctionDescriptorToIdWithUnits():Boolean[1]
 {
     assertEquals(
-        'my::test::testUnits_Mass~Kilogram_1__Mass~Kilogram_1_',
+        'my::test::testUnits_Mass$Kilogram_1__Mass$Kilogram_1_',
         'my::test::testUnits(Mass~Kilogram[1]):Mass~Kilogram[1]'->functionDescriptorToId());
     assertEquals(
-        'my::test::testUnits_Mass~Kilogram_1__Mass~Kilogram_1_',
+        'my::test::testUnits_Mass$Kilogram_1__Mass$Kilogram_1_',
         'my::test::testUnits( Mass ~ Kilogram [1..1] ) : Mass~Kilogram[1]'->functionDescriptorToId());
 }
diff --git a/pom.xml b/pom.xml
@@ -107,7 +107,7 @@
 
     <properties>
         <!-- Legend -->
-        <legend.pure.version>5.18.0</legend.pure.version>
+        <legend.pure.version>5.18.1</legend.pure.version>
         <legend.shared.version>0.25.6</legend.shared.version>
         <legend.web-application.version>12.43.0</legend.web-application.version>