Solution to issue #273 #279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadehamel
reviewed
Jul 1, 2024
| @@ -111,6 +111,7 @@ def get(cls, | |||
| id_type: Union[EntityIdentifier, str], | |||
| entity_type: Optional[Union[EntityType, str]] = None): | |||
| id_type = id_type.value if isinstance(id_type, Enum) else id_type | |||
| id_value = id_value.lower() # Convert to lowercase | |||
There was a problem hiding this comment.
Suggestion: Ensure that id_value is a string before calling .lower() to avoid potential errors if id_value is None or not a string.
if isinstance(id_value, str):
id_value = id_value.lower()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that some functionalities of the Country class expect the input for id to be in lower case, otherwise the 'get' function, for example, returns nothing. The issue is highlighted in #273.