Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate haskell-ci.yml to use Ubuntu 20.04 runners #73

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Regenerate haskell-ci.yml to use Ubuntu 20.04 runners #73

merged 3 commits into from
Feb 13, 2024

Conversation

RyanGlScott
Copy link
Collaborator

This regenerates haskell-ci.yml with a more recent haskell-ci version. Among other benefits, this changes the CI runners to use Ubuntu 20.04. Previously, they were targeting Ubuntu 18.04, which is no longer supported by GitHub Actions.

This regenerates `haskell-ci.yml` with a more recent `haskell-ci` version.
Among other benefits, this changes the CI runners to use Ubuntu 20.04.
Previously, they were targeting Ubuntu 18.04, which is no longer supported by
GitHub Actions.
@RyanGlScott
Copy link
Collaborator Author

The GHC 7.10 CI failure (seen here) is due to ndmitchell/safe#35. We could either wait for a resolution to that issue first, or we could drop support for GHC 7.10 as a workaround.

@RyanGlScott
Copy link
Collaborator Author

ndmitchell/safe#35 has now been fixed via a Hackage revision, so the failing GHC 7.10.3 CI job should hopefully pass now if you restart it.

@RyanGlScott
Copy link
Collaborator Author

Oops, the version bounds should have been constraints: safe < 0.3.18, not safe < 3.18. I've pushed a commit which rectifies this, and I've verified on my fork that CI finally passes with these changes.

This is necessary because newer versions of `safe` use the -W
syntax instead of the -fwarn syntax.
@RyanGlScott RyanGlScott merged commit 7e5baf6 into goldfirere:master Feb 13, 2024
11 checks passed
@RyanGlScott RyanGlScott deleted the regenerate-haskell-ci branch February 13, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants