Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snippets/go.json: update structure #2671

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zjffun
Copy link

@zjffun zjffun commented Feb 18, 2023

Update snippets structure for better compatibility with other extensions.

@gopherbot
Copy link
Collaborator

This PR (HEAD: b1a2366) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/469415 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@zjffun
Copy link
Author

zjffun commented Feb 18, 2023

How about update snippets structure for better compatibility with other extensions?

I make an extension to manage snippets and find it difficult to compatible with snippets of this extension, because of the nest structure. zjffun/vscode-snippets-manager#10

I read Snippets in Visual Studio Code and Snippet Guide | Visual Studio Code Extension API but not find nest format of snippets. Then I read source code, find it seems safe to remove .source.go wrap.
https://github.com/microsoft/vscode/blob/ecf479e662923a158c04ab58a835549a312442bf/src/vs/workbench/contrib/snippets/browser/snippetsFile.ts#L242-L248

Thank you.

@zjffun zjffun marked this pull request as ready for review February 18, 2023 10:02
@gopherbot
Copy link
Collaborator

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/469415.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants