Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codelens for running main func #2109

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vuon9
Copy link

@vuon9 vuon9 commented Mar 15, 2022

I've added a codelens for main func #159, here is how it looks like:
image

Additionally, I thought about another configuration flag to control keeping the output or clear the output, might be go.runMain.cleanPreviousOutput. Hope to hear the feedback.

Updates #159

@google-cla
Copy link

google-cla bot commented Mar 15, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@vuon9 vuon9 changed the title add codelens for running main func #159 add codelens for running main func Mar 15, 2022
@gopherbot
Copy link
Collaborator

This PR (HEAD: 76241b8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/393454 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/393454.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Polina Sokolova:

Patch Set 2:

(9 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/393454.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants