Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/goImpl: improve goimpl implememtations (#1547) #1592

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

src/goImpl: improve goimpl implememtations (#1547) #1592

wants to merge 9 commits into from
+76 −13,785

Commits on Jun 25, 2021

  1. Improve goimpl implememtations (golang#1547) 

    * change InputBox to QuickPick
* search workspace interface symbol according to keyword
* change static code text to code snippet
    @day-dreams
    day-dreams authored and kakaxizhang committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    c2e17a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2021

  1. src/goImpl.ts: improve goimp implementations 

    * change InputBox to QuickPick
* search workspace interface symbol according to keyword
* change static code text to code snippet

For golang#1547
    @day-dreams
    day-dreams authored and kakaxizhang committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    3cd9332 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Merge branch 'golang:master' into master

    @day-dreams
    day-dreams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    3c9d035 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2021

  1. Merge branch 'master' into pr1592 

    Change-Id: I7e26f492e584088a5e06d12d46561038d1069914
    @hyangah
    hyangah committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    f2bd27a View commit details
    Browse the repository at this point in the history

  2. .vscode/launch.json: recover launch.json 

    Change-Id: I3f85a665b111fc043bf226965d917838831f990f
    @hyangah
    hyangah committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    4776a3d View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. src/goImpl: remove unnecessary replacement 

    A space before Receiver__ makes the replacement never occurs.

Change-Id: Ibf0ee8bfa0004b942243dfb50a8d97f5683896e5
    @hyangah
    hyangah committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    368a049 View commit details
    Browse the repository at this point in the history

  2. package.json: npm install lodash 

    Change-Id: I736fdc6946abb8f5e9df9710ed52631706b08da3
    @hyangah
    hyangah committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    6994d90 View commit details
    Browse the repository at this point in the history

  3. src/goImpl: use quickpick description and handle symbol with . 

    If user searches with 'io.Reader' for more specific workspace
symbol search, the new interface returns 'io.Reader' as the
symbol name. Passing it to impl as it is will cause an error.
Use only the part after '.' as a heuristic.

Change-Id: I7935ad9ef59be50db0bc09890b9532c8e0ba32b6
    @hyangah
    hyangah committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    b2f06cc View commit details
    Browse the repository at this point in the history

  4. typings/lodash.d.ts: remove ancient copy of lodash.d.ts 

    Change-Id: I149d07ae251186898861089b66bee9ec5a57c7a7
    @hyangah
    hyangah committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    11dd0ec View commit details
    Browse the repository at this point in the history