You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fix is non-trivial and cannot be done before v0.42.0. Since this is a bug in the fake proxy arrangement and the test failure actually indicates the dlv installation with go1.19 or 1.20 pick the intended pinned versions.
The text was updated successfully, but these errors were encountered:
For go1.19 and go1.20, the extension tries to install a pinned version
of dlv (the last version that is compatible with the old go version).
The local proxy used for testing does not have the pinned version
so the test fails. Ironically this test failure indicates the dlv install
logic works as expected. Since the fix is non-trivial and hard to be
done before v0.42.0 release, skip them in go1.19/go1.20 CI.
For #3454
Change-Id: Iccd9d905ab46adf255c52d82817046d4fb85fe81
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/598196
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Hongxiang Jiang <[email protected]>
kokoro-CI: kokoro <[email protected]>
For example, https://github.com/golang/vscode-go/actions/runs/9938240939/job/27450273852
This is because the tests expect to install
dlv@latest
, but for go1.19 or go1.20, the extension pins the compatible dlv versionvscode-go/extension/src/goTools.ts
Lines 76 to 78 in 61901bb
and they do not exist in the fake local proxy.
The fix is non-trivial and cannot be done before v0.42.0. Since this is a bug in the fake proxy arrangement and the test failure actually indicates the dlv installation with go1.19 or 1.20 pick the intended pinned versions.
The text was updated successfully, but these errors were encountered: