Skip to content

Commit

Permalink
extension/test/integration: disable local dlv install tests
Browse files Browse the repository at this point in the history
For go1.19 and go1.20, the extension tries to install a pinned version
of dlv (the last version that is compatible with the old go version).
The local proxy used for testing does not have the pinned version
so the test fails. Ironically this test failure indicates the dlv install
logic works as expected. Since the fix is non-trivial and hard to be
done before v0.42.0 release, skip them in go1.19/go1.20 CI.

For #3454

Change-Id: Iccd9d905ab46adf255c52d82817046d4fb85fe81
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/598196
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Hongxiang Jiang <[email protected]>
kokoro-CI: kokoro <[email protected]>
  • Loading branch information
hyangah committed Jul 15, 2024
1 parent 64865db commit 13eebda
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions extension/test/integration/install.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,12 @@ suite('Installation Tests', function () {
);
});

test('Install multiple tools with a local proxy', async () => {
test('Install multiple tools with a local proxy', async function () {
// TODO(golang/vscode-go#3454): reenable the test for old go.
const systemGoVersion = await getGoVersion();
if (systemGoVersion.lt('1.21')) {
this.skip();
}
await runTest(
[
{ name: 'gopls', versions: ['v0.1.0', 'v1.0.0-pre.1', 'v1.0.0'], wantVersion: 'v1.0.0' },
Expand All @@ -199,7 +204,12 @@ suite('Installation Tests', function () {
);
});

test('Install multiple tools with a local proxy & GOBIN', async () => {
test('Install multiple tools with a local proxy & GOBIN', async function () {
// TODO(golang/vscode-go#3454): reenable the test for old go.
const systemGoVersion = await getGoVersion();
if (systemGoVersion.lt('1.21')) {
this.skip();
}
await runTest(
[
{ name: 'gopls', versions: ['v0.1.0', 'v1.0.0-pre.1', 'v1.0.0'], wantVersion: 'v1.0.0' },
Expand Down

0 comments on commit 13eebda

Please sign in to comment.