[release] prepare v0.35.2 release

073136d CHANGELOG.md: update for v0.35.2 8e5969f src/goToolsInformation: pick up gopls release 55683f5 src/goToolsInformation: update hardcoded gopls version 886decb tools: generate inlay hints settings from gopls settings 7467f26 README: edit Quickstart and Features section for clarity e4a94d2 .github/workflows: fix wiki.yml 84fe4e7 .github/workflows: add go1.19rc2 to long/smoke tests d114767 commands: add go.goroot command 484a3ba test/gopls/vulncheck: add logging for viewer test failure 5bf7237 test/integration/extension: disable all "Test Completion Snippets *" f4fcd7a test/integration/goDebug: make invalid flag test faster cbecbf8 test/integration/goExplorer: fix 'env tree items' test e91d0e8 test/integration/install: stub languageserver restart command a6729ef test/integration/goDebug: speed up setUpRemoteProgram 78c2fac Revert "src/goInstallTools: show error if go.languageserver.restart fails" aa3de7f test/integration: catch failed await in lint test b90e57e .vscode/launch.json: remove outFiles and deprecated attributes d2afd7d src/goTest/resolve: fix nested packageDisplayMode handling on win32 47f6dfa test/integration/goTest: fix populateModulePathCache 1adebbb test/integration/goTest.run: increase discover&run timeout ffae001 test/integration/goDebug: skip redundant tests in withConsole mode c909738 test/integration/goDebug: skip legacy da testing on windows a39ef24 package.json: remove tslint 1dfac14 .github/workflows: drop 1.15 from long test 944b1d4 .github/workflows: remove 'stable' unnecessary in setup-go@v3 21bbd7b test: skip flaky debug test 305bea7 .github/workflows: upgrade setup-go to v3 and enable caching b6aad3e .github/workflows: upgrade checkout/node workflows to v3 9bb57d8 test/integration: skip tests broken on windows b012df4 src/goInstallTools: show error if go.languageserver.restart fails c8598b1 test/integration/goDebug: catch any error while cleaning up 8f6cb5d goGenerateTests: resolve config file path aba3079 CHANGELOG.md: add v0.35.1 description bfdb91c package.json: update dev version 4bd0f33 docs/debugging.md: fix missing "" in example Change-Id: I7504ae5e6d9c40009ad0feb6317f7f1000987012
golang · Aug 11, 2022 · e314822 · e314822
2 parents 5e111fe + 073136d
commit e314822
Show file tree

Hide file tree

Showing 33 changed files with 596 additions and 645 deletions.
diff --git a/.github/workflows/release-nightly.yml b/.github/workflows/release-nightly.yml
@@ -18,17 +18,20 @@ jobs:
 
     steps:
       - name: Clone repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Setup Node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
-          node-version: '14.x'
+         node-version: '16'
+         cache: 'npm'
 
       - name: Setup Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
-         go-version: '1.18'
+         go-version: '1.19'
+         check-latest: true
+         cache: true
 
       - name: Install dependencies
         run: npm ci

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -37,8 +37,14 @@ jobs:
     if: github.repository == 'golang/vscode-go'
 
     steps:
-      - name: checkout code
-        uses: actions/checkout@v2
+      - name: Clone repository
+        uses: actions/checkout@v3
+
+      - name: Setup Node
+        uses: actions/setup-node@v3
+        with:
+          node-version: '16'
+          cache: 'npm'
 
       - name: get release version
         id: release_version

diff --git a/.github/workflows/test-long-all.yml b/.github/workflows/test-long-all.yml
@@ -17,22 +17,24 @@ jobs:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
         version: ['stable', 'insiders']
-        go: ['1.15', '1.16', '1.17', '1.18']
+        go: ['1.16', '1.17', '1.18', '1.19']
 
     steps:
       - name: Clone repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Setup Node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
-          node-version: '14.x'
+         node-version: '16'
+         cache: 'npm'
 
       - name: Setup Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
          go-version: ${{ matrix.go }}
-         stable: '!contains(${{ matrix.go }}, "beta") && !contains(${{ matrix.go }}, "rc")'
+         check-latest: true
+         cache: true
 
       - name: Install dependencies
         run: npm ci

diff --git a/.github/workflows/test-long.yml b/.github/workflows/test-long.yml
@@ -16,22 +16,24 @@ jobs:
       matrix:
         os: [ubuntu-latest, windows-latest] # TODO: reenable macos-latest
         version: ['stable']
-        go: ['1.15', '1.16', '1.17', '1.18']
+        go: ['1.16', '1.17', '1.18', '1.19']
 
     steps:
       - name: Clone repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Setup Node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
-          node-version: '14.x'
+         node-version: '16'
+         cache: 'npm'
 
       - name: Setup Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
          go-version: ${{ matrix.go }}
-         stable: '!contains(${{ matrix.go }}, "beta") && !contains(${{ matrix.go }}, "rc")'
+         check-latest: true
+         cache: true
 
       - name: Install dependencies
         run: npm ci

diff --git a/.github/workflows/test-smoke.yml b/.github/workflows/test-smoke.yml
@@ -14,22 +14,25 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest]
+        os: [ubuntu-latest, windows-latest]
         version: ['stable']
 
     steps:
       - name: Clone repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Setup Node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
-          node-version: '14.x'
+         node-version: '16'
+         cache: 'npm'
 
       - name: Setup Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
-         go-version: '1.18'
+         go-version: '1.19.0'
+         check-latest: true
+         cache: true
 
       - name: Install dependencies
         run: npm ci

diff --git a/.github/workflows/wiki.yml b/.github/workflows/wiki.yml
@@ -6,6 +6,7 @@ on:
     branches: [ master ]
     paths:
       - 'docs/**'
+      - '.github/workflows/wiki.yml'
 
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 permissions:
@@ -32,7 +33,13 @@ jobs:
           repository: ${{github.repository}}.wiki
           path: wiki
       - name: Setup Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
+        with:
+          go-version: '1.19'
+          check-latest: true
+          cache: true
+          cache-dependency-path: '**/go.sum'
+
       - name: Push to wiki
         run: |
           cd vscode-go

diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -22,7 +22,6 @@
 			"outFiles": [
                 "${workspaceFolder}/dist/**/*.js"
             ],
-			"stopOnEntry": false,
 			"sourceMaps": true,
 			"smartStep": true,
 			"preLaunchTask": "npm: bundle-dev",
@@ -33,7 +32,6 @@
 		{
 			"name": "Launch as server",
 			"type": "node",
-			"protocol": "inspector",
 			"request": "launch",
 			"program": "${workspaceFolder}/dist/debugAdapter.js",
 			"args": [
@@ -64,14 +62,9 @@
 				"VSCODE_GO_IN_TEST": "1",  // Disable code that shouldn't be used in test
 				"MOCHA_TIMEOUT": "999999",
 			},
-			"stopOnEntry": false,
 			"sourceMaps": true,
 			"smartStep": true,
-			"outFiles": [
-				"${workspaceFolder}/out/**/*.js",
-				"${workspaceFolder}/out/test/**/*.js"
-			],
-			"preLaunchTask": "npm: watch"
+			"preLaunchTask": "npm: watch",
 		},
 		{
 			"name": "Launch Extension Tests with Gopls",
@@ -89,12 +82,7 @@
 			"env": {
 				"VSCODE_GO_IN_TEST": "1"  // Disable code that shouldn't be used in test
 			},
-			"stopOnEntry": false,
 			"sourceMaps": true,
-			"outFiles": [
-				"${workspaceFolder}/out/**/*.js",
-				"${workspaceFolder}/out/test/**/*.js"
-			],
 			"preLaunchTask": "npm: watch",
 		},
 		{

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,14 @@
+## v0.35.2 - 15 Aug, 2022
+A list of all issues and changes can be found in the [v0.35.2 milestone](https://github.com/golang/vscode-go/milestone/51) and [commit history](https://github.com/golang/vscode-go/compare/v0.35.1...v0.35.2).
+
+### Changes
+
+This release includes a new [go.goroot command](https://github.com/golang/vscode-go/issues/2379), [fixes](https://github.com/golang/vscode-go/issues/2342) to the `Generate Tests` commands, and improvements for windows users.
+
+### Thanks
+
+Thank you for your contribution, @OrBin, @Ras96, @hyangah, @jamalcarvalho, and @suzmue!
+
 ## v0.35.1 - 19 July, 2022
 
 A list of all issues and changes can be found in the [v0.35.1 milestone](https://github.com/golang/vscode-go/milestone/50) and [commit history](https://github.com/golang/vscode-go/compare/v0.35.0...v0.35.1).

diff --git a/README.md b/README.md
@@ -24,17 +24,22 @@ Welcome! 👋🏻<br/>
 Whether you are new to Go or an experienced Go developer, we hope this
 extension fits your needs and enhances your development experience.
 
-* **Step 1.** If you haven't done so already, install [Go](https://golang.org)
-  and the [VS Code Go extension].
-  * [Go installation guide]. This extension works best with Go 1.14+.
-  * [Managing extensions in VS Code].
-* **Step 2.** To activate the extension, open any directory or workspace
-  containing Go code. Once activated, the [Go status bar](https://github.com/golang/vscode-go/wiki/ui) will
-  appear in the bottom left corner of the window and show the recognized Go
-  version.
-* **Step 3.** The extension depends on [a set of extra command-line tools](#tools).
-  If they are missing, the extension will show the "⚠️ Analysis Tools Missing"
-  warning. Click the notification to complete the installation.
+1.  Install [Go](https://golang.org) 1.14 or newer if you haven't already.
+
+1.  Install the [VS Code Go extension].
+
+1.  Open any directory or workspace containing Go code to automatically activate
+    the extension. The
+    [Go status bar](https://github.com/golang/vscode-go/wiki/ui) appears in the
+    bottom left corner of the window and displays your Go version.
+
+1.  The extension depends on `go`, `gopls`, `dlv` and other optional tools. If
+    any of the dependencies are missing, the ⚠️ `Analysis Tools Missing` warning
+    is displayed. Click on the warning to download dependencies.
+
+    See the
+    [tools documentation](https://github.com/golang/vscode-go/wiki/tools) for a
+    complete list of tools the extension depends on.
 
 <p align="center">
 <img src="docs/images/installtools.gif" width=75%>
@@ -44,23 +49,32 @@ extension fits your needs and enhances your development experience.
 
 You are ready to Go :-) &nbsp;&nbsp; 🎉🎉🎉
 
-Please be sure to learn more about the many [features](#features) of this
-extension, as well as how to [customize](#customization) them. Take a look at
-[Troubleshooting](https://github.com/golang/vscode-go/wiki/troubleshooting) and [Help](#ask-for-help) for further
-guidance.
+## What's next
+
+* Explore more [features](#features) of the VS Code Go extension.
+* Learn how to [customize](#customization) your settings.
+* Solve issues with
+  [Troubleshooting](https://github.com/golang/vscode-go/wiki/troubleshooting).
+* [file an issue](https://github.com/golang/vscode-go/issues/new/choose) for
+  problems with the extension.
+* Start a [GitHub discussion](https://github.com/golang/vscode-go/discussions)
+  or get help on [Stack Overflow].
 
 If you are new to Go, [this article](https://golang.org/doc/code.html) provides
 the overview on Go code organization and basic `go` commands. Watch ["Getting
 started with VS Code Go"] for an explanation of how to build your first Go
 application using VS Code Go.
 
-## Features
+## Feature highlights
+
+* [IntelliSense] - Results appear for symbols as you type.
+* [Code navigation] - Jump to or peek at a symbol's declaration.
+* [Code editing] - Support for saved snippets, formatting and code organization,
+  and automatic organization of imports.
+* [Diagnostics] -  Build, vet, and lint errors shown as you type or on save.
+* Enhanced support for [testing] and [debugging]
 
-This extension provides many features, including [IntelliSense],
-[code navigation], and [code editing] support. It also shows [diagnostics] as
-you work and provides enhanced support for [testing] and [debugging] your
-programs. See the [full feature breakdown] for more details and to learn how to
-tune its behavior.
+See the [full feature breakdown] for more details.
 
 <p align=center>
 <img src="docs/images/completion-signature-help.gif" width=75%>
@@ -182,8 +196,8 @@ conduct-related issue, please mail [email protected].
 [Go installation guide]: https://golang.org/doc/install
 ["Getting started with VS Code Go"]: https://youtu.be/1MXIGYrMk80
 [IntelliSense]: https://github.com/golang/vscode-go/wiki/features#intellisense
-[code navigation]: https://github.com/golang/vscode-go/wiki/features#code-navigation
-[code editing]: https://github.com/golang/vscode-go/wiki/features#code-editing
+[Code navigation]: https://github.com/golang/vscode-go/wiki/features#code-navigation
+[Code editing]: https://github.com/golang/vscode-go/wiki/features#code-editing
 [diagnostics]: https://github.com/golang/vscode-go/wiki/features#diagnostics
 [testing]: https://github.com/golang/vscode-go/wiki/features#run-and-test-in-the-editor
 [debugging]: https://github.com/golang/vscode-go/wiki/debugging#features

diff --git a/docs/commands.md b/docs/commands.md
@@ -27,6 +27,10 @@ Finally, you can also see a full list by using a meta command: `Go: Show All Com
 
 See the currently set GOPATH.
 
+### `Go: Current GOROOT`
+
+See the currently set GOROOT.
+
 ### `Go: Locate Configured Go Tools`
 
 List all the Go tools being used by this extension along with their locations.

diff --git a/docs/debugging-legacy.md b/docs/debugging-legacy.md
@@ -143,7 +143,7 @@ in your launch configuration. This property supports multiple tags, which you ca
 
 ### Specifying other build flags
 
-The flags specified in `buildFlags` and `env.GOFLAGS` are passed to the Go compiler when building your program for debugging. Delve adds `-gcflags='all=-N -l'` to the list of build flags to disable optimizations. User specified buildFlags conflict with this setting, so the extension removes them ([Issue #117](https://github.com/golang/vscode-go/issues/117)). If you wish to debug a program using custom `-gcflags`, build the program using `go build` and launch using `exec` mode:
+The flags specified in `buildFlags` and `env.GOFLAGS` are passed to the Go compiler when building your program for debugging. Delve adds `-gcflags=all="-N -l"` to the list of build flags to disable optimizations. User specified buildFlags conflict with this setting, so the extension removes them ([Issue #117](https://github.com/golang/vscode-go/issues/117)). If you wish to debug a program using custom `-gcflags`, build the program using `go build` and launch using `exec` mode:
 
 ```json
 {

diff --git a/docs/debugging.md b/docs/debugging.md
@@ -568,7 +568,7 @@ Start a `dlv dap` server ready to accept a client request to launch or attach to
 $ dlv dap --listen=:12345
 ```
 
-Use the following `launch` configuration to tell `dlv` to execute a binary precompiled with `go build -gcflags='all=-N -l'`:
+Use the following `launch` configuration to tell `dlv` to execute a binary precompiled with `go build -gcflags=all="-N -l"`:
 
 ```json5
 {
@@ -581,7 +581,7 @@ Use the following `launch` configuration to tell `dlv` to execute a binary preco
   "mode": "exec",
   "program": "/absolute/path/to/remote/workspace/program/executable",
   "substitutePath": [
-      { "from": ${workspaceFolder}, "to": "/path/to/remote/workspace" },
+      { "from": "${workspaceFolder}", "to": "/path/to/remote/workspace" },
       ...
   ]
 }
@@ -655,7 +655,7 @@ The "debug test" CodeLens and the [test UI](features.md#test-and-benchmark) do n
 
 ### Starting a debug session fails with `decoding dwarf section info at offset 0x0: too short` or `could not open debug info` error.
 
-These errors indicate that your binary was built with linker flags that stripped the symbol table (`-s`) or the DWARF debug information (`-w`), making debugging impossible. If the binary is built while launching the session, make sure your `launch.json` configuration does not contain `"buildFlags": "--ldflags '-s -w'"`. If you use `debug test` or Test Explorer, check `go.buildFlags` in `settings.json`. If the binary is built externally, check the command-line flags and do not use `go run`. Unlike `go build`, `go run` passes `-s -w` to the linker under the hood. If you try to attach to such a binary with a debugger, it will fail with one of the above errors (see Go Issue [24833](https://github.com/golang/go/issues/24833)). Instead let dlv build the binary for you or use `go build -gcflags='all=-N -l'`.
+These errors indicate that your binary was built with linker flags that stripped the symbol table (`-s`) or the DWARF debug information (`-w`), making debugging impossible. If the binary is built while launching the session, make sure your `launch.json` configuration does not contain `"buildFlags": "--ldflags '-s -w'"`. If you use `debug test` or Test Explorer, check `go.buildFlags` in `settings.json`. If the binary is built externally, check the command-line flags and do not use `go run`. Unlike `go build`, `go run` passes `-s -w` to the linker under the hood. If you try to attach to such a binary with a debugger, it will fail with one of the above errors (see Go Issue [24833](https://github.com/golang/go/issues/24833)). Instead let dlv build the binary for you or use `go build -gcflags=all="-N -l"`.
 
 ## Reporting Issues