Skip to content

Commit

Permalink
extension/tsconfig.json: target es2022
Browse files Browse the repository at this point in the history
Regexp capturing group used in extesion/src/goTest/utils.ts `moduleNameRegex`
is available from es2018

Originally targetted to switch to es2018, but Ethan Reesor pointed out
the current vscode-go targets vscode 1.75.0+ and according to
https://github.com/ewanharris/vscode-versions, it must be able to
support node 16.14.2+. node.green shows 16.14.2 supports up through
es2022. From https://compat-table.github.io/compat-table/es2016plus/
es2022 is widely supported. So, bump up to es2022.

Fixes #3540

Change-Id: I033ef645f77b06ca1c9cf5415f3c7c95887be409
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/606695
Reviewed-by: Ethan Reesor <[email protected]>
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
kokoro-CI: kokoro <[email protected]>
Auto-Submit: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Hongxiang Jiang <[email protected]>
  • Loading branch information
hyangah authored and gopherbot committed Sep 17, 2024
1 parent 91e723a commit 136441b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion extension/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
},
"engines": {
"vscode": "^1.75.0",
"node": ">=12.0.0"
"node": ">=16.14.2"
},
"activationEvents": [
"onLanguage:go",
Expand Down
4 changes: 2 additions & 2 deletions extension/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"module": "commonjs",
"outDir": "out",
"sourceMap": true,
"target": "es2017",
"target": "es2022",
"lib": [
"es2017"
"es2022"
],
"strict": true,
"esModuleInterop": true,
Expand Down

0 comments on commit 136441b

Please sign in to comment.