Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopls/internal/golang: improve extract variable edits #482

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gopls/internal/golang: improve extract variable edits #482

wants to merge 1 commit into from
+18 −4

Commits on Mar 2, 2024

  1. gopls/internal/golang: improve extract variable edits 

    The previous implementation use common edits to support both scenarios
where a assignment/declaration exist and did not exist. This cause a
additional text edit with lhs values in the new line when the
extraction was done on a expression which was not part of a
assignment/declaration. The new changes address this scenarios by
computing edits based on the scenario to avoid the additional lhs in
new line when extracted expression is not part of a
assignment/declaration.

Fixes golang/tools#65944
    @gayanper
    gayanper committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    ebc1a8b View commit details
    Browse the repository at this point in the history