Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design/68723-crypto-ssh-v2.md: new proposal #51

Closed
wants to merge 1 commit into from

Conversation

drakkan
Copy link
Member

@drakkan drakkan commented Aug 4, 2024

@gopherbot
Copy link

This PR (HEAD: e5bdd90) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/proposal/+/602855.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/602855.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from t hepudds:

Patch Set 1:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/602855.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 33f25dd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/proposal/+/602855.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Nicola Murino:

Patch Set 3: Code-Review+2

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/602855.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 22, 2024
For golang/go#68723
Updates golang/go#65269

Change-Id: Ied7a96ab990abe257c4b8c295e292f92a745a4a7
GitHub-Last-Rev: 33f25dd
GitHub-Pull-Request: #51
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/602855
Commit-Queue: Nicola Murino <[email protected]>
Reviewed-by: Nicola Murino <[email protected]>
Auto-Submit: Nicola Murino <[email protected]>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/602855 has been merged.

@gopherbot gopherbot closed this Aug 22, 2024
@drakkan drakkan deleted the sshv2 branch September 15, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants