Skip to content

Commit

Permalink
tests/screentest: update goldens
Browse files Browse the repository at this point in the history
Update the screentest goldens (*.want.png files) to capture the change
in https://go.dev/cl/621839, which reduced the "fading" at the
bottom of the truncated README to improve accessibility.

Also, add sleeps to some tests to deflake them.

Also, tell git to ignore screentest output.

Change-Id: I8d6f99db3503f0a448f9ba0b199a11e23370528b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/633997
LUCI-TryBot-Result: Go LUCI <[email protected]>
kokoro-CI: kokoro <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
  • Loading branch information
jba committed Dec 6, 2024
1 parent 2cbe989 commit 4a6e9bd
Show file tree
Hide file tree
Showing 17 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ go-discovery*.json
#### Loadtest Related Files ####
results.bin

#### Screentest Failure Output ####
tests/screentest/output

#### VS Code Debugger Files ####
.vscode
__debug_bin
Expand Down
2 changes: 2 additions & 0 deletions tests/screentest/testcases.txt
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ path /github.com/creack/[email protected]
wait {{$ready}}
eval {{$hideElements}}
eval {{$hideLinksHeading}}
sleep 1s
capture viewport
capture viewport 540x1080

Expand Down Expand Up @@ -166,6 +167,7 @@ test package with deprecated symbols symbol
path /database/sql/[email protected]#ColumnConverter
wait {{$ready}}
eval {{$hideElements}}
sleep 1s
capture viewport
# Screen doesn't scroll to symbol doc in chromedp.
# It works on a phone, however.
Expand Down
Binary file modified tests/screentest/testdata/testcases.ci/vuln-list.want.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/screentest/testdata/testcases.ci/vuln-search.want.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/screentest/testdata/testcases/empty-jump-to-modal.want.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/screentest/testdata/testcases/retracted-package.want.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/screentest/testdata/testcases/x-tools-540x1080.want.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/screentest/testdata/testcases/x-tools.want.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 4a6e9bd

Please sign in to comment.