Skip to content

Commit

Permalink
tests/screentest: remove a test cases
Browse files Browse the repository at this point in the history
Commented out the multi-GOOS 540x1080 test.

I tried and failed to increase its reliability. Running locally against
staging, it still fails about 20% of the time, but always succeeds after
a retry. Running on Cloud Build against staging, the failure rate seems
higher, and retries don't help.

More detail in a comment.

Change-Id: I31e334d03c6bdff6733ed675a97677a723309ce0
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/634555
LUCI-TryBot-Result: Go LUCI <[email protected]>
kokoro-CI: kokoro <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
  • Loading branch information
jba committed Dec 9, 2024
1 parent dc08416 commit 00b1eb0
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion tests/screentest/testcases.txt
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,12 @@ eval {{$hideElements}}
eval {{$hideLinksHeading}}
sleep 1s
capture viewport
capture viewport 540x1080
# This fails around 40% of the time with an 11-pixel difference. That is due to
# a slightly longer scrollbar. Changing "viewport" to "fullscreen" reveals that
# the real difference is the page length: there is extra blank space at the
# bottom of varying size.
# I have not been able to fix that or understand why it happens.
# capture viewport 540x1080

test retracted package
path /k8s.io/[email protected]
Expand Down

0 comments on commit 00b1eb0

Please sign in to comment.