route: treat short sockaddr lengths as unspecified #231

hurricanehrndz · 2025-02-04T22:56:34Z

Previously, we enforced minimum length requirements for sockaddr, but
the route command can legitimately parse shorter lengths. This change
treats any sockaddr with length less than the address offset as an
unspecified address (0.0.0.0 for IPv4 or :: for IPv6), as discern by
monitoring the route command.

To replicate the issue, prior to the fix, execute the following:

First:
route -n monitor

Next:
sudo route -n add -inet6 -ifscope en11 -net ::
-netmask :: fe80::2d0:4cff:fe10:15d2

The route command that is actively monitoring will print something such
as:
RTM_ADD: Add Route: len 152, pid: 81198, seq 1, errno 0, ifscope 13, flags:<UP,GATEWAY,DONE,STATIC,IFSCOPE>
locks: inits:
sockaddrs: <DST,GATEWAY,NETMASK>
:: fe80::2d0:4cff:fe10:15d2 ::

Prior to the fix, if you had attempted parse the above message, PareRIB
would have returned errInvalidAddr which is clearly false.

Fixes golang/go#71557

gopherbot · 2025-02-04T23:08:36Z

This PR (HEAD: 90f9dd9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/646556.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-02-04T23:57:12Z

Message from Ian Lance Taylor:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-04T23:57:13Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-04T23:46:16Z","revision":"b41e97f5344addd77d867722ea68bd205adcc8ab"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-04T23:57:14Z

Message from Ian Lance Taylor:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-04T23:57:14Z

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-04T23:57:15Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-05T00:21:27Z

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-05T00:21:31Z

This PR (HEAD: 085b4ee) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/646556.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Previously, we enforced minimum length requirements for sockaddr, but the route command can legitimately parse shorter lengths. This change treats any sockaddr with length less than the address offset as an unspecified address (0.0.0.0 for IPv4 or :: for IPv6), as discern by monitoring the route command. To replicate the issue, prior to the fix, execute the following: First, ```console route -n monitor ``` Next, ```console sudo route -n add -inet6 -ifscope en11 -net :: \ -netmask :: fe80::2d0:4cff:fe10:15d2 ``` The route command that is actively monitor will print something such as, ```console RTM_ADD: Add Route: len 152, pid: 81198, seq 1, errno 0, ifscope 13, flags:<UP,GATEWAY,DONE,STATIC,IFSCOPE> locks: inits: sockaddrs: <DST,GATEWAY,NETMASK> :: fe80::2d0:4cff:fe10:15d2 :: ``` Prior to the fix, if you had parse the above message, PareRIB would have returned errInvalidAddr which is clearly false. Fixes golang/go#71557

gopherbot · 2025-02-05T00:29:25Z

Message from Carlos Hernandez:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-05T00:38:08Z

This PR (HEAD: 396d8a2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/646556.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-02-05T00:46:09Z

Message from Damien Neil:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-05T01:02:00Z

Message from Ian Lance Taylor:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-05T15:43:52Z

Message from Carlos Hernandez:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

On Darwin, the AF_FAMILY byte of a sockaddr for a netmask or genmask can be ignored if unreasonable. In such cases, it is the family of the DST address that should instead be used. Depends on golang#231. Fixes golang/go#71578.

gopherbot · 2025-02-06T18:25:58Z

Message from Ian Lance Taylor:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-06T18:25:59Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-06T18:17:08Z","revision":"d18399381daf5e8d6ef5d5e1b807b9c0cb3b6524"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-06T18:34:21Z

Message from Ian Lance Taylor:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-06T18:34:21Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-06T18:34:22Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/646556.
After addressing review feedback, remember to publish your drafts!

Previously, we enforced minimum length requirements for sockaddr, but the route command can legitimately parse shorter lengths. This change treats any sockaddr with length less than the address offset as an unspecified address (0.0.0.0 for IPv4 or :: for IPv6), as discern by monitoring the route command. To replicate the issue, prior to the fix, execute the following: First: route -n monitor Next: sudo route -n add -inet6 -ifscope en11 -net :: \ -netmask :: fe80::2d0:4cff:fe10:15d2 The route command that is actively monitoring will print something such as: RTM_ADD: Add Route: len 152, pid: 81198, seq 1, errno 0, ifscope 13, flags:<UP,GATEWAY,DONE,STATIC,IFSCOPE> locks: inits: sockaddrs: <DST,GATEWAY,NETMASK> :: fe80::2d0:4cff:fe10:15d2 :: Prior to the fix, if you had attempted parse the above message, PareRIB would have returned errInvalidAddr which is clearly false. Fixes golang/go#71557 Change-Id: Iec86cc9b05a765b6e67e95a4e30ff31f66f3d17e GitHub-Last-Rev: 396d8a2 GitHub-Pull-Request: #231 Reviewed-on: https://go-review.googlesource.com/c/net/+/646556 Commit-Queue: Ian Lance Taylor <[email protected]> Reviewed-by: Damien Neil <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>

gopherbot · 2025-02-06T20:34:35Z

This PR is being closed because golang.org/cl/646556 has been merged.

hurricanehrndz mentioned this pull request Feb 4, 2025

x/net/route: ParseRIB still panics on macOS golang/go#71557

Closed

hurricanehrndz force-pushed the fix_golang_go_71557 branch from 90f9dd9 to 085b4ee Compare February 5, 2025 00:18

hurricanehrndz force-pushed the fix_golang_go_71557 branch from 085b4ee to 396d8a2 Compare February 5, 2025 00:30

hurricanehrndz mentioned this pull request Feb 6, 2025

route: fix RTM_GET netmask parsing on Darwin #232

Closed

gopherbot closed this Feb 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

route: treat short sockaddr lengths as unspecified #231

route: treat short sockaddr lengths as unspecified #231

hurricanehrndz commented Feb 4, 2025 •

edited

Loading

gopherbot commented Feb 4, 2025

gopherbot commented Feb 4, 2025

gopherbot commented Feb 4, 2025

gopherbot commented Feb 4, 2025

gopherbot commented Feb 4, 2025

gopherbot commented Feb 4, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

route: treat short sockaddr lengths as unspecified #231

route: treat short sockaddr lengths as unspecified #231

Conversation

hurricanehrndz commented Feb 4, 2025 • edited Loading

gopherbot commented Feb 4, 2025

gopherbot commented Feb 4, 2025

gopherbot commented Feb 4, 2025

gopherbot commented Feb 4, 2025

gopherbot commented Feb 4, 2025

gopherbot commented Feb 4, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 5, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

hurricanehrndz commented Feb 4, 2025 •

edited

Loading