net/http/httptest: ensure that a superfluous WriteHeader call panics in httptest #69440
+18
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
net/http
, usingWriteHeader()
twice creates a log entry, since the second one is superfluous:https://cs.opensource.google/go/go/+/refs/tags/go1.23.1:src/net/http/server.go;l=1201
In
net/http/httptest
though, while a check is made, there is no way to detect the superfluous usage.That makes superfluous calls reasy to reach production runtimes.
To help prevent that, this change proposes rejecting any superfluous
WriteHeader
calls in thehttptest
package.