Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: make sure the linker for shared doesn't include tempdir path #69394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmd/go: make sure the linker for shared doesn't include tempdir path #69394

wants to merge 1 commit into from
+25 −1

Commits on Sep 19, 2024

  1. cmd/go: make sure the linker for shared doesn't include tempdir path 

    This is similar to CL 478196 and CL 477296,
but this is for -buildmode=shared.

When using "go install -buildmode=shared std",
because the gold linker is used by default on Linux arm64,
it will cause temporary paths to be included in libstd.so.

Based on the changes of CL 478196,
I speculate that this may also have issues on other platforms.
So, this change is for all platform.

But I don't have any other platforms and
don't know what the file name for verification,
so the testcase are only for the Linux platform.
I hope someone can improve this testcase. Thanks!

Fixes golang#69464
    @And-ZJ
    And-ZJ committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ee40cf8 View commit details
    Browse the repository at this point in the history