Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/md5: improve ARM64 MD5 performance by optimizing ROUND3 function #69302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

crypto/md5: improve ARM64 MD5 performance by optimizing ROUND3 function #69302

wants to merge 1 commit into from
+14 −4

Commits on Sep 6, 2024

  1. crypto/md5: improve ARM64 MD5 performance by optimizing ROUND3 function 

    This commit enhances the performance of the MD5 functionality on ARM64 architecture by optimizing the ROUND3 function in the `md5block_arm64.s` assembly file.

1.Refactored the `ROUND3` macro to improve the computation order, introducing a new `ROUND3FIRST` macro to handle the initial calculation more efficiently.
2.Optimized the XOR operations in the `ROUND3` macro to reduce unnecessary instructions and improve parallelism within the ARM64 architecture.

Performance testing was conducted on an ARM64 Linux machine using Go's benchmark tool. The benchmarks were run 10 times each to ensure statistical significance. The following results were observed:

| Benchmark             | Old Time (sec/op) | New Time (sec/op) | Change |
|-----------------------|-------------------|-------------------|--------|
| Hash8Bytes-8          | 175.0ns  2%      | 175.0ns  1%      | ~      |
| Hash1K-8              | 2.065µs  0%      | 2.060µs  0%      | -0.22% |
| Hash8K-8              | 15.31µs  0%      | 15.29µs  0%      | -0.11% |
| Hash8BytesUnaligned-8 | 174.0ns  1%      | 174.0ns  1%      | ~      |
| Hash1KUnaligned-8     | 2.067µs  0%      | 2.059µs  0%      | -0.41% |
| Hash8KUnaligned-8     | 15.44µs  0%      | 15.45µs  0%      | ~      |

    In terms of throughput:

| Benchmark             | Old Throughput (B/s) | New Throughput (B/s) | Change |
|-----------------------|----------------------|----------------------|--------|
| Hash8Bytes-8          | 43.58MiB/s  2%      | 43.69MiB/s  0%      | +0.24% |
| Hash1K-8              | 473.1MiB/s  0%      | 474.0MiB/s  0%      | +0.20% |
| Hash8K-8              | 510.4MiB/s  0%      | 511.0MiB/s  0%      | +0.11% |
| Hash8BytesUnaligned-8 | 43.80MiB/s  0%      | 43.82MiB/s  0%      | ~      |
| Hash1KUnaligned-8     | 472.5MiB/s  0%      | 474.3MiB/s  0%      | +0.38% |
| Hash8KUnaligned-8     | 506.1MiB/s  0%      | 505.8MiB/s  0%      | ~      |

When testing with large files (e.g., a 3GB file), the runtime was reduced from 8.65 seconds to 7.39 seconds, resulting in an approximate 9% reduction in execution time. This demonstrates a more significant performance gain when handling larger datasets.

Overall, these optimizations provide modest improvements for small input sizes and more noticeable performance benefits when processing larger files, especially in memory-intensive workloads like file hashing.
    Jade Zhao authored and wangqiang committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3149567 View commit details
    Browse the repository at this point in the history