cmd/go: cache coverage profile with tests #50483
Conversation
|
This PR (HEAD: 9ada311) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/376134 to see it. Tip: You can toggle comments from me using the |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/376134. |
|
I tried this PR with |
|
Thanks for the feedback @vearutop ! I agree that this change is unlikely to make it into 1.18. It's too risky this late in the release cycle. I decided to open the PR anyway in case the community wanted to test and review before the Go team does. I appreciate you taking the time to try it out and I'm happy to hear it works 😃 |
|
Message from James Roberts: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/376134. |
|
Message from Than McIntosh: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/376134. |
jproberts
force-pushed
the
cache-coverprofile-with-tests
branch
from
74b0e24
to
de26ed4
Compare
|
This PR (HEAD: de26ed4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/376134 to see it. Tip: You can toggle comments from me using the |
|
Message from James Roberts: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/376134. |
|
Message from Bryan Mills: Patch Set 2: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/376134. |
jproberts
force-pushed
the
cache-coverprofile-with-tests
branch
2 times, most recently
from
4c5fb3c
to
3e83a00
Compare
|
This PR (HEAD: 3e83a00) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/376134 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 6c1281a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/376134 to see it. Tip: You can toggle comments from me using the |
|
Message from James Roberts: Patch Set 4: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/376134. |
|
Message from Bryan Mills: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/376134. |
jproberts
force-pushed
the
cache-coverprofile-with-tests
branch
from
6c1281a
to
0990fbf
Compare
|
This PR (HEAD: 0990fbf) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/376134 to see it. Tip: You can toggle comments from me using the |
|
Message from James Roberts: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/376134. |
|
Message from Than McIntosh: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/376134. |
|
This PR (HEAD: af9a74c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/376134 to see it. Tip: You can toggle comments from me using the |
|
Message from James Roberts: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/376134. |
This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Fixes golang#23565
jproberts
force-pushed
the
cache-coverprofile-with-tests
branch
from
af9a74c
to
ace4a17
Compare
|
This PR (HEAD: ace4a17) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/376134. Important tips:
|
This CL stores coverage profile data in the GOCACHE under the
'coverprofile' subkey alongside tests. This makes tests which use
coverage profiles cacheable. The values of the -coverprofile and
-outputdir flags are not included in the cache key to allow cached
profile data to be written to any output file.
Note: This is a rebase and squash from the original PRs golang#50483 and golang#65657 that was
created/closed by @jproberts and @macnibblet that I plan to maintain.
I made improvements to the PR based on feedback from @bcmills.
From @macnibblet:
I don't know if anyone has considered the environmental impact
(Yes, of course, dev experience too), but on a team with 3 backend
developers, when I replaced our CI Golang version with this build,
it reduced the build time by 50%, which would have
equated to about 5000 hours of CI reduced in the past year.
Fixes golang#23565
Signed-off-by: Ryan Currah <[email protected]>
This CL stores coverage profile data in the GOCACHE under the
'coverprofile' subkey alongside tests. This makes tests which use
coverage profiles cacheable. The values of the -coverprofile and
-outputdir flags are not included in the cache key to allow cached
profile data to be written to any output file.
Note: This is a rebase and squash from the original PRs golang#50483 and golang#65657 that was
created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain.
I made improvements to the PR based on feedback from @bcmills here https://go-review.googlesource.com/c/go/+/563138.
y
From @macnibblet:
I don't know if anyone has considered the environmental impact
(Yes, of course, dev experience too), but on a team with 3 backend
developers, when I replaced our CI Golang version with this build,
it reduced the build time by 50%, which would have
equated to about 5000 hours of CI reduced in the past year.
Fixes golang#23565
Signed-off-by: Ryan Currah <[email protected]>
This CL stores coverage profile data in the GOCACHE under the
'coverprofile' subkey alongside tests. This makes tests which use
coverage profiles cacheable. The values of the -coverprofile and
-outputdir flags are not included in the cache key to allow cached
profile data to be written to any output file.
Note: This is a rebase and squash from the original PRs golang#50483 and golang#65657 that was
created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain.
I made improvements to the PR based on feedback from @bcmills here https://go-review.googlesource.com/c/go/+/563138.
From @macnibblet:
I don't know if anyone has considered the environmental impact
(Yes, of course, dev experience too), but on a team with 3 backend
developers, when I replaced our CI Golang version with this build,
it reduced the build time by 50%, which would have
equated to about 5000 hours of CI reduced in the past year.
Fixes golang#23565
Signed-off-by: Ryan Currah <[email protected]>
This CL stores coverage profile data in the GOCACHE under the
'coverprofile' subkey alongside tests. This makes tests which use
coverage profiles cacheable. The values of the -coverprofile and
-outputdir flags are not included in the cache key to allow cached
profile data to be written to any output file.
Note: This is a rebase and squash from the original PRs golang#50483 and golang#65657 that was
created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain.
I made improvements to the PR based on feedback from @bcmills here https://go-review.googlesource.com/c/go/+/563138.
From @macnibblet:
I don't know if anyone has considered the environmental impact
(Yes, of course, dev experience too), but on a team with 3 backend
developers, when I replaced our CI Golang version with this build,
it reduced the build time by 50%, which would have
equated to about 5000 hours of CI reduced in the past year.
Fixes golang#23565
Signed-off-by: Ryan Currah <[email protected]>
This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - golang#50483 - golang#65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565
This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - golang#50483 - golang#65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565
This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - golang#50483 - golang#65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565
This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - golang#50483 - golang#65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565
This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - golang#50483 - golang#65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565
This CL stores coverage profile data in the GOCACHE under the
'coverprofile' subkey alongside tests. This makes tests which use
coverage profiles cacheable. The values of the -coverprofile and
-outputdir flags are not included in the cache key to allow cached
profile data to be written to any output file.
Fixes #23565