-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/viewcore: migrate from chzyer/readline to ergochat/readline #21
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: eb26bbb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/debug/+/610555. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/610555. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/610555. |
Message from Keith Randall: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/610555. |
eb26bbb
to
46be18b
Compare
This PR (HEAD: 46be18b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/debug/+/610555. Important tips:
|
Message from Keith Randall: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/610555. |
Module ergochat/readline is a fork that is actively maintained and includes numerous bug fixes that are not present in the original module. Additionally, this change reduces the number of indirect dependencies by removing the need for github.com/chzyer/logex and github.com/chzyer/test. Details: - Updated imports and removed old module dependencies. - Replaced Terminal field references with Stdout method calls for shell output. - Modified the cmdToCompleter function to adapt to the new PrefixCompleter structure. - Ensured the completion tree is built using the new SetChildren and Children methods. Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
46be18b
to
cac3e03
Compare
Message from Mikel Olasagasti: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/610555. |
This PR (HEAD: cac3e03) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/debug/+/610555. Important tips:
|
Message from Keith Randall: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/610555. |
Module ergochat/readline is a fork that is actively maintained and includes numerous bug fixes that are not present in the original module. Additionally, this change reduces the number of indirect dependencies by removing the need for github.com/chzyer/logex and github.com/chzyer/test.
Details: