-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboard: fix env/dragonfly-amd64 build #88
Conversation
Due to several factors as an old pkg version in the ISO, or the amount of changes that have gone to the binary packages since 6.4.0 was released, a bit of a workaround is needed in phase2.sh
This PR (HEAD: 76b78fd) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/build/+/568315. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/568315. |
Message from Dmitri Shuralyov: Patch Set 2: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/568315. |
Message from Dmitri Shuralyov: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/568315. |
Message from Carlos Amedee: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/568315. |
Message from Carlos Amedee: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/568315. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-18T14:23:08Z","revision":"e33e7f61584a80b78964d4bdea76e990a64edae4"} Please don’t reply on this GitHub thread. Visit golang.org/cl/568315. |
Message from Carlos Amedee: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/568315. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/568315. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/568315. |
any news? |
What are the next steps please? |
@tuxillo Note that almost nobody sees comments on this pull request. See the note automatically added to #88 (comment). I've picked this up and will see if it is ready to go. Thanks. |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/568315. |
Message from Ian Lance Taylor: Patch Set 3: Auto-Submit+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/568315. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-16T22:56:37Z","revision":"de8113b840067138b244305de4e3c3cee7ae30ec"} Please don’t reply on this GitHub thread. Visit golang.org/cl/568315. |
Due to several factors as an old pkg version in the ISO, or the amount of changes that have gone to the binary packages since 6.4.0 was released, a bit of a workaround is needed in phase2.sh For golang/go#64684. Change-Id: I233fcfb77c3cc2f0b04331ad7bfee5892193622a GitHub-Last-Rev: 76b78fd GitHub-Pull-Request: #88 Reviewed-on: https://go-review.googlesource.com/c/build/+/568315 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
This PR is being closed because golang.org/cl/568315 has been merged. |
Due to several factors as an old pkg version in the ISO, or the amount
of changes that have gone to the binary packages since 6.4.0 was
released, a bit of a workaround is needed in phase2.sh
For golang/go#64684.