Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gopherbot: relaxed matching rule for the documentation label #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

codebien
Copy link

Documentation word is more specific than the document word to match issues related to Documentation.

Fixes golang/go#31153

Documentation word is more specific than document to match issues related to Documentation.

Fixes golang/go#31153
@gopherbot
Copy link
Contributor

This PR (HEAD: ea2aec8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/182419 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1: Code-Review-1

We still want gopherbot to add Documentation on titles like:

net/http: document the rules around xxxxx

So this patch as-is isn't correct. If you want to not match "textDocument" as in the bug, then the match should be more like /\bdocument\b/. (But for performance reasons, don't use regexps for word boundary detection unless the "document" substring first matches)


Please don’t reply on this GitHub thread. Visit golang.org/cl/182419.
After addressing review feedback, remember to publish your drafts!

When the title contains the word document then
repeat the check with a regex word boundaries rule then
return positive just in case of a whole word match.

Updates golang/go#31153
@gopherbot
Copy link
Contributor

This PR (HEAD: 8247ae2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/182419 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ivan Palladino:

Patch Set 2:

Patch Set 1: Code-Review-1

We still want gopherbot to add Documentation on titles like:

net/http: document the rules around xxxxx

So this patch as-is isn't correct. If you want to not match "textDocument" as in the bug, then the match should be more like /\bdocument\b/. (But for performance reasons, don't use regexps for word boundary detection unless the "document" substring first matches)

Done


Please don’t reply on this GitHub thread. Visit golang.org/cl/182419.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrew Bonventre:

Patch Set 2:

Can you add a test or update an existing one? Thanks.


Please don’t reply on this GitHub thread. Visit golang.org/cl/182419.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1: Code-Review-1

We still want gopherbot to add Documentation on titles like:

net/http: document the rules around xxxxx

So this patch as-is isn't correct. If you want to not match "textDocument" as in the bug, then the match should be more like /\bdocument\b/. (But for performance reasons, don't use regexps for word boundary detection unless the "document" substring first matches)


Please don’t reply on this GitHub thread. Visit golang.org/cl/182419.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ivan Palladino:

Patch Set 2:

Patch Set 1: Code-Review-1

We still want gopherbot to add Documentation on titles like:

net/http: document the rules around xxxxx

So this patch as-is isn't correct. If you want to not match "textDocument" as in the bug, then the match should be more like /\bdocument\b/. (But for performance reasons, don't use regexps for word boundary detection unless the "document" substring first matches)

Done


Please don’t reply on this GitHub thread. Visit golang.org/cl/182419.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrew Bonventre:

Patch Set 2:

Can you add a test or update an existing one? Thanks.


Please don’t reply on this GitHub thread. Visit golang.org/cl/182419.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/build/cmd/gopherbot: too aggressive for issue titles that contain the word "document"
3 participants