Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:add sha512's 224 and 256 byte truncated versions #240

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Conversation

mertakman
Copy link
Collaborator

@mertakman mertakman commented Dec 23, 2024

This PR covers OpenSSL repo stage for microsoft/go#1456 . Implementing SHA512_224 and SHA_256 hashes functions and one shot versions.

@mertakman mertakman marked this pull request as draft December 23, 2024 15:39
@gdams gdams requested review from qmuntal and gdams December 23, 2024 15:45
@mertakman mertakman marked this pull request as ready for review December 23, 2024 15:51
Copy link
Collaborator

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the new hash objects to the HMAC test suite (here:

{"sha512", openssl.NewSHA512},
). Other than that, LGTM.

@mertakman
Copy link
Collaborator Author

Add the new hash objects to the HMAC test suite (here:

{"sha512", openssl.NewSHA512},

). Other than that, LGTM.

Added.

@mertakman mertakman requested a review from qmuntal December 23, 2024 16:13
@qmuntal qmuntal merged commit 9c8cba8 into v2 Dec 25, 2024
54 checks passed
@qmuntal qmuntal deleted the add-sha512-224-256 branch December 25, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants