This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
Handle app process crash. #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-novikov
commented
Aug 8, 2017
| } | ||
|
|
||
| if (second == null) null else first to second | ||
| } | ||
| .filterNotNull() | ||
| .map { (first, second) -> | ||
| InstrumentationTest( | ||
| index = first.current, |
There was a problem hiding this comment.
Printing test index and total test count sharded to particular device really helps.
dmitry-novikov
requested review from
artem-zinnatullin,
arturdryomov and
yunikkk
yunikkk
approved these changes
Aug 8, 2017
artem-zinnatullin
approved these changes
Aug 8, 2017
| Exception("Instrumentation was unable to run tests using runner $runner.\n" + | ||
| private fun String.throwIfError(output: File) = when { | ||
| contains("INSTRUMENTATION_RESULT: shortMsg=Process crashed") -> { | ||
| throw Exception("Application process crashed. Check Logcat output for more details.") |
| .takeWhile { !it.startsWith("INSTRUMENTATION_CODE") } | ||
| .map { it.throwIfError(output) } | ||
| .takeWhile { | ||
| // `INSTRUMENTATION_CODE: <code>` is the last line printed by instrumentation, even if 0 tests were run. |
| ) | ||
| } | ||
| adbDevice.log( | ||
| "Test ${test.index}/${test.total} $status in " + |
There was a problem hiding this comment.
Super nice, I actually wanted this in #82
|
@yunikkk can you ship a release with this please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue when
Composerfails to recognize that app process under the test is crashed that leads to successful completion.