Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The target all includes setup to install golint, goveralls before executing build and coverage #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Biswajee
Copy link

@Biswajee Biswajee commented Jan 9, 2022

Expected: The command make executes successfully.

Actual: The command make fails with /bin/sh: 1: goveralls: not found

make-doesnt-download-goveralls

Potential reason: The Makefile has the .PHONY target: all that may execute the targets: build, test, coverage. However, the command make fails as the prerequisites are not downloaded before executing the targets.

What changes were made in the PR:

  1. Removed unnecessary strings attached with the .PHONY target.
  2. Added the target setup in the all target so that golint and goveralls are installed before executing the build and coverage targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant