[Ft]:[DEVX-8764]:Clickstream Health refactor #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitij6325
force-pushed
the
feature/kshitij/health-refractor
branch
from
ac815f7
to
4238201
Compare
kshitij6325
changed the base branch from
main
to
feature/kshitij/clickstream-refractor
kshitij6325
changed the base branch from
feature/kshitij/clickstream-refractor
to
main
kshitij6325
force-pushed
the
feature/kshitij/health-refractor
branch
from
4238201
to
4d996b2
Compare
akashraje
requested changes
Aug 9, 2023
clickstream-logger/src/main/kotlin/clickstream/logger/CSLogger.kt
Outdated
Show resolved
Hide resolved
clickstream-logger/src/main/kotlin/clickstream/logger/CSLogger.kt
Outdated
Show resolved
Hide resolved
clickstream/src/main/kotlin/clickstream/internal/db/CSAppVersionSharedPref.kt
Outdated
Show resolved
Hide resolved
| * @param eventGUID | ||
| * @param timeStamp | ||
| */ | ||
| internal data class CSEventSpecificData( |
There was a problem hiding this comment.
We don't use this. Should we remove it?
clickstream/src/main/kotlin/clickstream/internal/eventscheduler/CSBackgroundScheduler.kt
Outdated
Show resolved
Hide resolved
clickstream-health-metrics-api/src/main/kotlin/clickstream/health/model/CSHealthEvent.kt
Show resolved
Hide resolved
kshitij6325
force-pushed
the
feature/kshitij/health-refractor
branch
from
4d996b2
to
301d2cf
Compare
akashraje
previously approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring Clickstream
Refactoring Health Tracking
Health tracking is now managed by CSHealthProcessor. Changes: