Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Overlay Issue in Replication Page UI #21069

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

bupd
Copy link
Member

@bupd bupd commented Oct 21, 2024

Summary

  • Fixes overflow of text in Turkish and German languages.

Before Fix

377610748-aad0c054-8c8f-4050-920f-aa0e44b6c8ef

After Fix

after fix ofoveflow

Issue being fixed

Fixes #21059

Changes made

  • increase width from 100px to 150px to support two words.

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@bupd bupd requested a review from a team as a code owner October 21, 2024 11:31
@Vad1mo Vad1mo added the release-note/update Update or Fix label Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.20%. Comparing base (c8c11b4) to head (b172b97).
Report is 361 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21069      +/-   ##
==========================================
+ Coverage   45.36%   46.20%   +0.83%     
==========================================
  Files         244      247       +3     
  Lines       13333    13883     +550     
  Branches     2719     2875     +156     
==========================================
+ Hits         6049     6415     +366     
- Misses       6983     7130     +147     
- Partials      301      338      +37     
Flag Coverage Δ
unittests 46.20% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@Vad1mo Vad1mo added area/ui target/2.13.0 issues that are targeting v2.13.0 labels Dec 9, 2024
@bupd bupd changed the title Fix #21059 Ui Overlay Issue in Replication Fix Overlay Issue in Replication Page UI Dec 16, 2024
@bupd bupd force-pushed the fix-repl-ui branch 2 times, most recently from 7695bf5 to 9f373c8 Compare December 20, 2024 02:05
@Vad1mo Vad1mo enabled auto-merge (squash) December 20, 2024 15:12
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vad1mo Vad1mo merged commit a668890 into goharbor:main Jan 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui release-note/update Update or Fix target/2.13.0 issues that are targeting v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Overlay Issue in Replication
4 participants