Add GitHub action for code quality checks (#13)

gofrp · Jun 6, 2024 · eba69aa · eba69aa
1 parent 791a33d
commit eba69aa
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 3 deletions.
diff --git a/.github/workflows/go-code-check.yml b/.github/workflows/go-code-check.yml
@@ -0,0 +1,27 @@
+name: Go Code Check
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.21'
+
+      - name: Build
+        run: make
+
+      - name: Vet
+        run: go vet ./...
diff --git a/cmd/frpc/default_runner.go b/cmd/frpc/default_runner.go
@@ -24,7 +24,7 @@ var runner model.Runner = defaultRunner{}
 
 type defaultRunner struct{}
 
-func (r defaultRunner) New(commonCfg *v1.ClientCommonConfig, pxyCfg []v1.ProxyConfigurer, vCfg []v1.VisitorConfigurer) (err error) {
+func (r defaultRunner) Init(commonCfg *v1.ClientCommonConfig, pxyCfg []v1.ProxyConfigurer, vCfg []v1.VisitorConfigurer) (err error) {
 	log.Infof("init default runner")
 	return
 }

diff --git a/cmd/frpc/nssh_runner.go b/cmd/frpc/nssh_runner.go
@@ -40,7 +40,7 @@ type NativeSSHRun struct {
 	cancelFunc context.CancelFunc
 }
 
-func (nr *NativeSSHRun) New(commonCfg *v1.ClientCommonConfig, pxyCfg []v1.ProxyConfigurer, vCfg []v1.VisitorConfigurer) error {
+func (nr *NativeSSHRun) Init(commonCfg *v1.ClientCommonConfig, pxyCfg []v1.ProxyConfigurer, vCfg []v1.VisitorConfigurer) error {
 	log.Infof("init native ssh runner")
 
 	nr.ctx, nr.cancelFunc = context.WithCancel(context.Background())

diff --git a/pkg/model/interface.go b/pkg/model/interface.go
@@ -19,7 +19,7 @@ import (
 )
 
 type Runner interface {
-	New(commonCfg *v1.ClientCommonConfig, pxyCfg []v1.ProxyConfigurer, vCfg []v1.VisitorConfigurer) error
+	Init(commonCfg *v1.ClientCommonConfig, pxyCfg []v1.ProxyConfigurer, vCfg []v1.VisitorConfigurer) error
 	Run() error
 	Close() error
 }