Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Tune call depth limit to 32 #63

Draft
wants to merge 4 commits into
base: compatibility-breaking-changes
Choose a base branch
from
Draft

Tune call depth limit to 32 #63

wants to merge 4 commits into from

Conversation

Flouse
Copy link
Collaborator

@Flouse Flouse commented Jul 20, 2021 •
edited
Loading

Call depth is limited to 32, due to 4 MB maximum runtime memory for running contracts in CKB VM.

  • Add test case for this

@TheWaWaR
Copy link
Contributor

Please update docs/EVM-compatible.md for this limitation.

@Flouse Flouse changed the title Tune call depth limit to 64 Tune call depth limit to 32 Jul 20, 2021
TheWaWaR
TheWaWaR previously approved these changes Jul 21, 2021
View reviewed changes
@Flouse Flouse marked this pull request as draft July 28, 2021 03:41
@jjyr
Copy link
Collaborator

jjyr commented Jul 28, 2021

Is this PR ready for review?

@Flouse
Copy link
Collaborator Author

Flouse commented Jul 28, 2021 •
edited
Loading

Not ready.
I think we need more statistics about contract call depth to redefine our design target.
Maybe depth <= 32 is not enough?

@Flouse Flouse changed the base branch from main to compatibility-breaking-changes January 23, 2022 03:27
@Flouse Flouse requested a review from jjyr January 23, 2022 03:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TheWaWaR TheWaWaR TheWaWaR left review comments

@jjyr jjyr Awaiting requested review from jjyr

Assignees

@magicalne magicalne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Flouse @TheWaWaR @jjyr @magicalne @floustar