Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup of tests (testing with swoole on 8.3, removed all warnings) #79

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

jklab
Copy link
Contributor

@jklab jklab commented Nov 23, 2024

No description provided.

@jklab jklab changed the title cleanup of tests (testing with swoole on 8.3, removed all warnings) chore: cleanup of tests (testing with swoole on 8.3, removed all warnings) Nov 23, 2024
Copy link
Owner

@godruoyi godruoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jakub, Love your PR, just left a nit suggestion, fell free update whenever you can,

composer.json Show resolved Hide resolved
tests/BatchSnowflakeIDTest.php Show resolved Hide resolved
tests/FileLockResolverTest.php Outdated Show resolved Hide resolved
@jklab jklab force-pushed the chore/tests-cleanup branch from bcb7c27 to d2fb0ff Compare November 27, 2024 20:57
@godruoyi
Copy link
Owner

thank you @jklab, great work.

@godruoyi godruoyi merged commit 68aa747 into godruoyi:master Nov 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants