feat: support predis #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
godruoyi
commented
Apr 6, 2024
•
godruoyi
commented
- fix tests
- update readme
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
============================================
+ Coverage 98.71% 98.74% +0.02%
- Complexity 91 94 +3
============================================
Files 7 8 +1
Lines 234 239 +5
============================================
+ Hits 231 236 +5
Misses 3 3 ☔ View full report in Codecov by Sentry. |
godruoyi
commented
Apr 6, 2024
Bilge
suggested changes
Apr 6, 2024
There was a problem hiding this comment.
I couldn't help but notice this does not follow my suggestion to use the adapter pattern, but instead implements an entirely separate SequenceResolver. I still think the adapter pattern would work better, unless you have some specific reason why you disagree?
Co-authored-by: Bilge <[email protected]>
godruoyi
added
the
Ready to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.