SCons: Apply new ruff/mypy fixes #102371
Merged
SCons: Apply new ruff/mypy fixes #102371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
approved these changes
Feb 3, 2025
Repiteo
commented
Feb 3, 2025
| @@ -499,7 +499,7 @@ def build_gles3_header( | |||
| fd.write("\t\t};\n\n") | |||
| variant_count = len(header_data.variant_defines) | |||
| else: | |||
| fd.write("\t\tstatic const char **_variant_defines[]={" "};\n") | |||
| fd.write('\t\tstatic const char **_variant_defines[]={" "};\n') | |||
There was a problem hiding this comment.
This was the offending line, as the original fix was:
- fd.write("\t\tstatic const char **_variant_defines[]={" "};\n")
+ fd.write("\t\tstatic const char **_variant_defines[]={};\n")The intent was to have the fallback container store a single value, but the outer double quotes meant Python was concatenating two strings instead, resulting in an empty container. Using single quotes restores the intended behavior.
Chubercik
approved these changes
Feb 3, 2025
akien-mga
approved these changes
Feb 3, 2025
|
@Chubercik By default, pre-commit only runs on files that were locally changed. You'll have to be more explicit otherwise, but it can be trimmed down to just the hooks you want to run: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff&mypypre-commit hooks #102246Integrates new fixes found by the updated mypy/ruff hooks. Should've done this during/before the above PR was merged, but I forgot 🙃. This goes beyond codestyle, as a regression was identified and fixed in the process.