Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git-ignore built Godot.app package #101989

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

MartinMajewski
Copy link
Contributor

@MartinMajewski MartinMajewski commented Jan 24, 2025

Following the "compiling for Mac" tutorial, one will eventually end with a Godot.app package inside the repo folder. To prevent it from being tracked by git, I added it to .gitignore.

Building Godot from the source will result in dozens of untracked/unstaged new files/changes as an app package is a folder. This entry also prevents git from seeing all files inside the "Godot.app" folder.

Following the "compiling for mac" tutorial one will eventually end with a Godot.app package inside the repo folder. To prevent it from being tracked by git, it has been added to gitignore.
@MartinMajewski MartinMajewski requested a review from a team as a code owner January 24, 2025 15:16
@MartinMajewski MartinMajewski changed the title Ignore built Godot.app package Git-ignore built Godot.app package Jan 24, 2025
@AThousandShips AThousandShips added this to the 4.x milestone Jan 24, 2025
@MartinMajewski
Copy link
Contributor Author

Any updates? Is this a valid point? It would declutter the folder. :-)

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Feb 10, 2025
@akien-mga akien-mga changed the title Git-ignore built Godot.app package Git-ignore built Godot.app package Feb 10, 2025
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guide should probably be updated to export the files in bin/ instead of the root, but this makes sense in the meantime

@Repiteo Repiteo merged commit 66b0eff into godotengine:master Feb 10, 2025
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Feb 10, 2025

Thanks! Congratulations on your first merged contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants