OpenXR: add binding modifiers documentation to action map #10430
+355
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
commented
Dec 20, 2024
BastiaanOlij
force-pushed
the
openxr_binding_modifiers_docs
branch
4 times, most recently
from
86a5d87 to
122f7a5
Compare
mhilbrunner
reviewed
Dec 20, 2024
mhilbrunner
reviewed
Dec 20, 2024
mhilbrunner
reviewed
Dec 20, 2024
mhilbrunner
reviewed
Dec 20, 2024
tetrapod00
reviewed
Dec 21, 2024
BastiaanOlij
force-pushed
the
openxr_binding_modifiers_docs
branch
from
122f7a5 to
2bf3d03
Compare
|
Ok I think I've got all feedback covered. I hard-wrapped the whole document so including the existing part of the documentation.. |
tetrapod00
approved these changes
Dec 27, 2024
|
Seems okay to merge but ideally someone else can review for XR first |
mhilbrunner
approved these changes
Dec 27, 2024
|
Gonna trust Bastiaan on XR stuff. :) Looks good to me, thank you and happy holidays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding documentation about the new binding modifier logic in the action map.
Contributed by Khronos Group through the Godot Integration Project