-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show warning box if page is outdated #10411
Only show warning box if page is outdated #10411
Conversation
Approving, although I'm wondering whether now that the dust has mostly settled, we should just have the "this page is outdated" one - a page not being outdated should be the expected state if there's nothing mentioned, after all? This was different once when nearly everything was outdated due to Godot 4 being heavily WIP. It may even help a little bit with the notice-boxes-everywhere issue. |
100% in favor of no longer displaying the The docs being generally up to date is expected behavior, and displaying a box to say that a page is up to date adds clutter to the page. The continued existence of the The one point in favor of the |
Pushed an update to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Considering the time of the year, I'm going to leave this open for a bit so others can still chime in.
Edit: for posterity, we already have thumb ups on this on RC from Mickeon, PatrickFlameLizard, Akien and Emi.
7445452
to
f47af1f
Compare
❄️ I think we have enough consensus to go ahead with this. Thanks everyone, and thanks tetrapod :) |
Additionally, changes the color of the warning box from green (tip colored) to orange (warning colored), which closes #7196.
Looks like this:
We no longer display this admonition declaring the page up to date:
There are 46 of these outdated pages remaining.
(Originally, this PR only color-coded the boxes as the linked issue asks for.)