Correctly free property and method lists #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-670 |
Bromeon
force-pushed
the
jovan/script_instance_list_free
branch
from
6307996 to
d070dfe
Compare
TitanNano
force-pushed
the
jovan/script_instance_list_free
branch
from
d070dfe to
b14f4d1
Compare
|
Thanks 🙂 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Uh, CI again... will need to see if this is an issue that's also happening with other branches... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the patch for #554 I noticed that both
free_property_list_funcandfree_method_list_funcare not correctly freeing their data.Property List
free_property_list_funcstill uses theScriptInstancetrait to obtain the list length. This is incorrect. It should take the length of theVecwhich is being removed from theHashMap.Method List
Has the same issue as the property list but, moreover, it is also never dropping the
Vecinside theHashMap. So this memory is effectively leaked.