test: add unit test for binding arguments to static-method callables #1029
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arocull
force-pushed
the
static-callable-test
branch
2 times, most recently
from
6384178 to
7e11a42
Compare
arocull
changed the title
Bromeon
force-pushed
the
static-callable-test
branch
from
7e11a42 to
abe5667
Compare
arocull
force-pushed
the
static-callable-test
branch
5 times, most recently
from
309976d to
bae2387
Compare
|
This is complete I think, unless there is anything I should change or if I need to wait on anything. |
arocull
force-pushed
the
static-callable-test
branch
from
bae2387 to
25d3c39
Compare
|
Thanks! Will try to reserve some time in the next couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some issues with binding arguments to static method
Callables. @Bromeon suggested I make a PR to add some unit tests.I'm new to contributing and I don't fully understand the Rust toolchain, so looking for feedback.
cfg!(since_api="4.4")seeing as the callable API has changed a bit in that Godot version? How can I run this test with that API if so?Test fails, indicating a bug. Should I just, comment it out to prevent interrupting workflows?Commented it out for now