Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singleton unregister fix + refcounted #31

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

StatisMike
Copy link
Contributor

No description provided.

Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
Added some comments. CI lints are also failing.

src/recipes/engine-singleton.md Outdated Show resolved Hide resolved
src/recipes/engine-singleton.md Outdated Show resolved Hide resolved
src/recipes/engine-singleton.md Outdated Show resolved Hide resolved
src/recipes/engine-singleton.md Outdated Show resolved Hide resolved
@Bromeon Bromeon added the error Mistake in the book label Jan 30, 2024
@StatisMike StatisMike force-pushed the hotfix/singletons branch 2 times, most recently from 6edfcfd to cd3b5de Compare January 30, 2024 19:28
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

src/recipes/engine-singleton.md Outdated Show resolved Hide resolved
@Bromeon
Copy link
Member

Bromeon commented Feb 1, 2024

Thanks! Lints are now failing because you used 1 character too many 😁
Otherwise good to go! 👍

@Bromeon Bromeon merged commit c4a329d into godot-rust:master Feb 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error Mistake in the book
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants