add support for struct entities in MakeVariant
#391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guelfey
force-pushed
the
fix/struct_variant
branch
from
2390784
to
5d47bee
Compare
guelfey
force-pushed
the
fix/struct_variant
branch
from
0353a2a
to
d7d2556
Compare
currently, structs are not parsed properly since `format()` has no handling for the reflect type add a switch case to handle structs and encode some sane defaults if given an empty one resolves #328 Signed-off-by: Charlie Doern <[email protected]>
guelfey
force-pushed
the
fix/struct_variant
branch
from
d7d2556
to
85e276e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #329