-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #86
Draft
agibson-godaddy
wants to merge
16
commits into
master
Choose a base branch
from
chore/update-dependencies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So this exists:
|
This might fix it but need more testing c5edd07 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates many dependencies. I also committed the lock file. If we commit that then we can use dependabot in the future.
It turns out I wasn't able to update as many dependencies as I'd like. (See "ESM Packages" note below for reasons why.
gulp-imagemin
in particular has a ton of vulnerabilities but we can't upgrade any further.)Notes
ESM Packages
I didn't update the following packages (or not all the way to latest) because they're now ESM packages, which would require doing significant overhauls to our whole code base. (which we should do at some point, but not part of this PR!)
See https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
chalk
dateformat
strip-ansi
gulp-imagemin
inquirer
I have created a follow-up JIRA story to update our code base to ESM https://godaddy-corp.atlassian.net/browse/MWC-17961
gulp-clean
I removed
gulp-clean
in favour ofdel
because the former has been deprecated: https://www.npmjs.com/package/gulp-cleanEmpty Directories
After updating (maybe gulp?) I started getting errors when entire directories don't exist. For example:
I'd run:
sake imagemin
And get this error:
And in fact that directory doesn't exist, because the correct one for the plugin I was testing (PDF vouchers) is
/assets/images/
but the plugin fails to customize that in the Sake config.tl;dr: for some reason in older versions I wouldn't get an error if the entire directory doesn't exist, but in newer versions I do. So I hardened some checks around checking if a directory exists before using it. (Reference: gulpjs/glob-stream#134 (comment))
Vulnerabilities stemming from
gulp-saas-lint
I created a follow-up story to address vulnerabilities as a result of
gulp-saas-lint
. See https://godaddy-corp.atlassian.net/browse/MWC-17960This will require replacing an entire package.
QA
sake build
works successfully for plugin using blockssake build
works successfully for plugin using saassake deploy
completes successful - I deployed https://github.com/gdcorp-partners/woocommerce-sequential-order-numbers-pro/releases/tag/1.21.4 with this branch