Update dependencies

[agibson-godaddy]

This updates many dependencies. I also committed the lock file. If we commit that then we can use dependabot in the future.

It turns out I wasn't able to update as many dependencies as I'd like. (See "ESM Packages" note below for reasons why. gulp-imagemin in particular has a ton of vulnerabilities but we can't upgrade any further.)

Notes

ESM Packages

I didn't update the following packages (or not all the way to latest) because they're now ESM packages, which would require doing significant overhauls to our whole code base. (which we should do at some point, but not part of this PR!)

See https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

• chalk
• dateformat
• strip-ansi
• gulp-imagemin
• inquirer

I have created a follow-up JIRA story to update our code base to ESM https://godaddy-corp.atlassian.net/browse/MWC-17961

gulp-clean

I removed gulp-clean in favour of del because the former has been deprecated: https://www.npmjs.com/package/gulp-clean

Empty Directories

After updating (maybe gulp?) I started getting errors when entire directories don't exist. For example:

I'd run: sake imagemin

And get this error:

[15:42:14] Using gulpfile ~/Projects/sake/gulpfile.js
[15:42:14] Starting 'imagemin'...
[15:42:14] 'imagemin' errored after 22 ms
[15:42:14] Error: ENOENT: no such file or directory, scandir 'wp-content/plugins/woocommerce-pdf-product-vouchers/assets/img'

And in fact that directory doesn't exist, because the correct one for the plugin I was testing (PDF vouchers) is /assets/images/ but the plugin fails to customize that in the Sake config.

tl;dr: for some reason in older versions I wouldn't get an error if the entire directory doesn't exist, but in newer versions I do. So I hardened some checks around checking if a directory exists before using it. (Reference: gulpjs/glob-stream#134 (comment))

Vulnerabilities stemming from gulp-saas-lint

I created a follow-up story to address vulnerabilities as a result of gulp-saas-lint. See https://godaddy-corp.atlassian.net/browse/MWC-17960

This will require replacing an entire package.

QA

• sake build works successfully for plugin using blocks
  • the build/ directory does not have another build/ directory inside of it
• sake build works successfully for plugin using saas
  • the build/ directory does not have another build/ directory inside of it
• sake deploy completes successful - I deployed https://github.com/gdcorp-partners/woocommerce-sequential-order-numbers-pro/releases/tag/1.21.4 with this branch

[agibson-godaddy]

⚠️ Reverting this to draft. I realized that sake build for some reason includes its own build directory recursively!

So this exists:

build/woocommerce-pdf-product-vouchers/build/woocommerce-pdf-product-vouchers/build/

[agibson-godaddy]

This might fix it but need more testing c5edd07

[agibson-godaddy]

Seems like it worked so re-opening this.

[nmolham-godaddy]

Amazing work as usual @agibson-godaddy. I just notice something with Sass, I am getting this deprecation warning:

Deprecation Warning [legacy-js-api]: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0

I think we don't have to worry about it for now, but something to note

[agibson-godaddy]

Thanks @nmolham-godaddy ! I've created a new jira story to address that deprecation notice later: https://godaddy-corp.atlassian.net/browse/MWC-18016