Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use value comparators for LEAST, GREATEST, BETWEEN #182

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

ohaibbq
Copy link
Contributor

@ohaibbq ohaibbq commented Feb 27, 2024

Closes #177

@codecov-commenter
Copy link

Codecov Report

Merging #182 (e83577f) into main (961ce06) will increase coverage by 0.13%.
The diff coverage is 85.71%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   46.39%   46.52%   +0.13%     
==========================================
  Files          47       47              
  Lines       17828    17831       +3     
==========================================
+ Hits         8271     8296      +25     
+ Misses       8111     8081      -30     
- Partials     1446     1454       +8     

@goccy
Copy link
Owner

goccy commented Mar 9, 2024

Thank you for your great PR !!!!

@goccy goccy merged commit 1d9b417 into goccy:main Mar 9, 2024
6 checks passed
@ohaibbq ohaibbq deleted the dan/between-greatest-least branch March 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LEAST(), GREATEST(), BETWEEN() do not work for string values
3 participants