[Aggreagate] Poroperly return nil for STRING_AGG when called with…

… null or 0-length array (#154)

internal/function_aggregate.go

@@ -494,13 +494,19 @@ func (f *STRING_AGG) Done() (Value, error) {
 		f.values = f.values[:minLen]
 	}
 	values := make([]string, 0, len(f.values))
+
+	foundNotNilValue := false
 	for _, v := range f.values {
 		text, err := v.Value.ToString()
 		if err != nil {
 			return nil, err
 		}
+		foundNotNilValue = true
 		values = append(values, text)
 	}
+	if !foundNotNilValue {
+		return nil, nil
+	}
 	return StringValue(strings.Join(values, f.delim)), nil
 }
 

query_test.go

@@ -842,6 +842,16 @@ SELECT LOGICAL_OR(x) AS logical_or FROM toks`,
 			query:        `SELECT STRING_AGG(fruit) AS string_agg FROM UNNEST(["apple", NULL, "pear", "banana", "pear"]) AS fruit`,
 			expectedRows: [][]interface{}{{"apple,pear,banana,pear"}},
 		},
+		{
+			name:         "string_agg with length 0",
+			query:        `SELECT STRING_AGG(fruit) FROM UNNEST(ARRAY<STRING>[]) fruit;`,
+			expectedRows: [][]interface{}{{nil}},
+		},
+		{
+			name:         "string_agg with null",
+			query:        `SELECT STRING_AGG(null) FROM UNNEST(ARRAY<STRING>[]);`,
+			expectedRows: [][]interface{}{{nil}},
+		},
 		{
 			name:         "string_agg with delimiter",
 			query:        `SELECT STRING_AGG(fruit, " & ") AS string_agg FROM UNNEST(["apple", "pear", "banana", "pear"]) AS fruit`,