Fix indentation for raw string newlines #625
Open
+83
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #625 +/- ##
=======================================
Coverage 77.36% 77.36%
=======================================
Files 22 22
Lines 7885 7887 +2
=======================================
+ Hits 6100 6102 +2
Misses 1368 1368
Partials 417 417 |
shuheiktgw
commented
Jan 22, 2025
| @@ -28,8 +28,6 @@ const ( | |||
| type Encoder struct { | |||
| writer io.Writer | |||
| opts []EncodeOption | |||
| indent int | |||
There was a problem hiding this comment.
The Encoder previously had two fields, indent and indentNum, but indentNum was not being used anywhere. Since the name indentNum is used elsewhere, I migrated the functionality of the indent field to the indentNum field and removed the indent field.
shuheiktgw
commented
Jan 22, 2025
| if e.indentSequence { | ||
| e.column -= e.indentNum | ||
| } | ||
| }() |
There was a problem hiding this comment.
Minor refactoring to ensure the subtraction 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #292
Before submitting your PR, please confirm the following.