This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
fixed racing condition of the simple worker #2266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new standard (reusable) testing workflow detected racing conditions on the buffalo core, and they were all in the Simple Worker. The root cause was basically:
PerformIn()
can be called while configuring theApp
and they use the default context.Start(context)
with a new context whenApp.Serve()
is called after theApp
setup was finished.Additionally, the Worker spec is not clear enough for each function's purpose and expected actions. We need to revisit this when we design the next version. (#2242)
Perform*()
is not clear. Their actual action should be enqueuing (not to perform the job by itself) even though the Simple Worker does perform the job.Perform*()
) is allowed.Anyway, this PR will fix the issue for now and will make the new testing works fine. (#2265)