Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/kerberos: use new python-kadmin implementation #11932

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rissson
Copy link
Member

@rissson rissson commented Nov 5, 2024

Details


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@rissson rissson self-assigned this Nov 5, 2024
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit dfee490
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/672bc4ea4ff07b00086bacfb
😎 Deploy Preview https://deploy-preview-11932--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit dfee490
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/672bc4ea29aaa600087199d6

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.57%. Comparing base (05b5987) to head (dfee490).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/sources/kerberos/models.py 62.50% 3 Missing ⚠️
authentik/sources/kerberos/signals.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11932      +/-   ##
==========================================
- Coverage   92.65%   92.57%   -0.08%     
==========================================
  Files         761      761              
  Lines       37813    37815       +2     
==========================================
- Hits        35035    35008      -27     
- Misses       2778     2807      +29     
Flag Coverage Δ
e2e 49.11% <50.00%> (-0.16%) ⬇️
integration 24.91% <50.00%> (+<0.01%) ⬆️
unit 90.15% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-dfee490636a33ea8f439cbe34a448a4c22e95807
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-dfee490636a33ea8f439cbe34a448a4c22e95807-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-dfee490636a33ea8f439cbe34a448a4c22e95807

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-dfee490636a33ea8f439cbe34a448a4c22e95807-arm64

Afterwards, run the upgrade commands from the latest release notes.

@rissson rissson marked this pull request as ready for review November 6, 2024 19:35
@rissson rissson requested a review from a team as a code owner November 6, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant