Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings #126

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Fix warnings #126

merged 3 commits into from
Mar 26, 2024

Conversation

NotNite
Copy link
Contributor

@NotNite NotNite commented Mar 16, 2024

Some are just blatant null! and !, some are disabling warnings in places they don't make sense (Veldrid device creation), some are actual null checks.

image

@Blooym Blooym self-requested a review March 16, 2024 15:15
Blooym
Blooym previously approved these changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@Blooym Blooym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine on Linux

@Blooym
Copy link
Contributor

Blooym commented Mar 16, 2024

Going to daily drive this locally for a few days to ensure that everything works as expected.

Everything seems fine right now though, so I don't expect any changes being needed.

@rankynbass
Copy link
Contributor

rankynbass commented Mar 16, 2024 •
edited
Loading

I'm having problems building this in a flatpak. Getting a bunch these errors:

/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(143,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(145,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(168,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(170,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(178,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(180,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(181,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(182,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]
/run/build/xivlauncher/src/XIVLauncher.Core/Support/Troubleshooting.cs(183,36): error CS8652: The feature 'required members' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version. [/run/build/xivlauncher/src/XIVLauncher.Core/XIVLauncher.Core.csproj]

@NotNite
Copy link
Contributor Author

NotNite commented Mar 16, 2024

Ah, must be because required doesn't work in NET 6. One moment...

@rankynbass
Copy link
Contributor

Builds in flatpak now.

@philpax
Copy link

philpax commented Mar 23, 2024

This seems reasonable. Happy to merge if @Blooym hasn't encountered any issues.

Blooym
Blooym approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@Blooym Blooym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed a few login flows without issues, lgtm

@Blooym Blooym merged commit 19c4bd1 into goatcorp:main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blooym Blooym Blooym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NotNite @Blooym @rankynbass @philpax